-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARKR] [HOTFIX] Disable flaky SparkR package build test #9744
Conversation
@@ -369,6 +369,9 @@ class SparkSubmitSuite | |||
} | |||
} | |||
|
|||
// TODO(SPARK-9603): Building a package is flaky on Jenkins Maven builds. | |||
// See https://gist.github.com/shivaram/3a2fecce60768a603dac for a error log | |||
/* | |||
test("correctly builds R packages included in a jar with --packages") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks OK, but you can just do ignore
here instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on preferring ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. I was just reverting the commit in #9390 which removed this comment
Test build #46021 has started for PR 9744 at commit |
Test build #46016 has finished for PR 9744 at commit
|
Good to merge ? |
Merging into master 1.6. |
See #9390 (comment) and https://gist.github.com/shivaram/3a2fecce60768a603dac for more information Author: Shivaram Venkataraman <[email protected]> Closes #9744 from shivaram/sparkr-package-test-disable. (cherry picked from commit ea6f53e) Signed-off-by: Andrew Or <[email protected]>
…table Backport #9390 and #9744 to branch-1.5. Author: Sun Rui <[email protected]> Author: Shivaram Venkataraman <[email protected]> Closes #10372 from sun-rui/SPARK-10500-branch-1.5.
See #9390 (comment) and https://gist.github.com/shivaram/3a2fecce60768a603dac for more information