Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARKR] [HOTFIX] Disable flaky SparkR package build test #9744

Closed
wants to merge 2 commits into from

Conversation

shivaram
Copy link
Contributor

@shivaram
Copy link
Contributor Author

cc @JoshRosen @brkyvz @sun-rui

@@ -369,6 +369,9 @@ class SparkSubmitSuite
}
}

// TODO(SPARK-9603): Building a package is flaky on Jenkins Maven builds.
// See https://gist.github.com/shivaram/3a2fecce60768a603dac for a error log
/*
test("correctly builds R packages included in a jar with --packages") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK, but you can just do ignore here instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on preferring ignore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. I was just reverting the commit in #9390 which removed this comment

@SparkQA
Copy link

SparkQA commented Nov 16, 2015

Test build #46021 has started for PR 9744 at commit 3ca6f13.

@SparkQA
Copy link

SparkQA commented Nov 16, 2015

Test build #46016 has finished for PR 9744 at commit efe9c36.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor Author

Good to merge ?

@andrewor14
Copy link
Contributor

Merging into master 1.6.

asfgit pushed a commit that referenced this pull request Nov 17, 2015
See #9390 (comment) and https://gist.github.com/shivaram/3a2fecce60768a603dac for more information

Author: Shivaram Venkataraman <[email protected]>

Closes #9744 from shivaram/sparkr-package-test-disable.

(cherry picked from commit ea6f53e)
Signed-off-by: Andrew Or <[email protected]>
@asfgit asfgit closed this in ea6f53e Nov 17, 2015
asfgit pushed a commit that referenced this pull request Dec 18, 2015
…table

Backport #9390 and #9744 to branch-1.5.

Author: Sun Rui <[email protected]>
Author: Shivaram Venkataraman <[email protected]>

Closes #10372 from sun-rui/SPARK-10500-branch-1.5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants